Re: Reduce logging during prepared transaction recovery

[Ashutosh Sharma]

Hi,

Thanks for your review comments/suggestions.

On Wed, Oct 28, 2026 at 5:15 PM Fujii Masao <masao.fu...@gmail.com> wrote:
>
> On Wed, Oct 28, 2026 at 7:15 PM Ashutosh Sharma <ashu.coe...@gmail.com> wrote:
> > Thanks for the review and suggestions. I agree that we can verify
> > these changes by adding log checks to the existing TAP test for
> > two-phase transactions. I’ve done that in the attached patch, which is
> > based on the changes suggested in your earlier patch. Please take a
> > look and let me know if you have any other comments.
>
> Thanks for updating the patch!
>
> -               ereport(LOG,
> +               ereport(DEBUG1,
>
> Do we want to keep this debug message translatable? If not, we could
> simplify this to elog().
>
> Also, DEBUG2 might be more consistent with per-transaction messages
> in PrepareRedoAdd() and PrepareRedoRemoveFull()? Those use elog(DEBUG2, ...).
> This would also avoid flooding the log at DEBUG1.
>

It's a developer-facing message, so I agree that it doesn't need to be
translatable. I've changed it to elog(DEBUG2, ...) in the attached
patch, consistent with PrepareRedoAdd() and PrepareRedoRemoveFull().

--
With Regards,
Ashutosh Sharma.

v3-0001-Reduce-logging-during-prepared-transaction-recovery.patch
Description: Binary data