On Tue, Nov 10, 2026 at 3:23 PM Chao Li <[email protected]> wrote: > ``` > + /* > + * ATTSTATS_NUM_FIELDS corresponds to the number of statistical value > + * parameters for import_attribute_statistics(), which is larger than > that > + * for import_relation_statistics(). Therefore, a NullableDatum > array of > + * that length is used to store data for each parameter in both > functions. > + */ > NullableDatum args[ATTSTATS_NUM_FIELDS]; > ``` > > I think this comment is slightly inaccurate. ATTSTATS_NUM_FIELDS is 14, > including ATTSTATS_ATTNAME as 0. So the number of statistical value > parameters is 13. import_attribute_statistics() needs 14 NullableDatatum > including a “version” argument plus 13 statistical value parameters.
As I understand it, you are saying we need to separate the version parameter from statistical value parameters, but the comment for import_attribute_statistics says: * Import attribute statistics from NullableDatum inputs for all statistical * values. * * For now, the 'version' argument is ignored. In the future it can be used * to interpret older statistics properly. So IMU I think we are using the term "statistical value parameters" to include the version parameter. With that in mind, what I proposed is not that bad... Thanks for reviewing! Best regards, Etsuro Fujita
