On Tue, Nov 17, 2026 at 12:35 AM Masahiko Sawada <[email protected]> wrote: > > On Sun, Nov 15, 2026 at 9:13 AM Zhijie Hou <[email protected]> wrote: > > > > > BTW, since we are changing the callback signature anyway, another wild > > idea would be to pass ReorderBufferChange directly instead so that it is > > fully consistent with the other change callbacks. That said, it would > > require more changes in third-party output plugins, so I don't insist on > > it if you disagree — just sharing for reference. > > It seems overkill to me. For non-transactional messages, we don't > create a ReorderBufferChange for them, so we would have to allocate > one just for the callback and copy the prefix and the message into it. > We would still need a separate transactional argument, so I guess it > would not help us pass more information than the xid does. >
+1. I also thought about it but didn't see this as an improvement as we still won't be able to remove the existing parameter like prefix which we are separately passing extracting them from ReorderBufferChange. -- With Regards, Amit Kapila.
