Hi, On Thu, Nov 19, 2026 at 03:42:06PM -0800, Masahiko Sawada wrote: > On Thu, Nov 19, 2026 at 2:49 AM Amit Kapila <[email protected]> wrote: > > > > On Wed, Nov 18, 2026 at 12:13 PM Bertrand Drouvot > > <[email protected]> wrote: > > > > > > On Tue, Nov 17, 2026 at 02:14:15PM -0800, Masahiko Sawada wrote: > > > > On Tue, Nov 17, 2026 at 12:14 AM Bertrand Drouvot > > > > <[email protected]> wrote: > > > > > > > Given that the 0001 patch is not backpatched, I think the subscriber > > > > should request the messages option only from v20 or later publishers, > > > > like it doesn't send the origin option to publishers older than v16. > > > > The patch already checks the publisher version there, so we just need > > > > to raise it from v14 to v20. What do you think? > > > > > > One difference with origin is that older publishers do not support that > > > option > > > at all, whereas v14 through v19 publishers support messages and the issue > > > occurs > > > only when streaming is enabled. > > > > > > I wonder if it would make sense to request messages from those publishers > > > when > > > streaming is disabled, and require v20 or later when streaming is enabled? > > > > > > > We could use one of the ideas proposed or just leave as it is. It is > > possible that there is no such use till now, so, adding more version > > checking in the code for such things may not add much value. > > I'd like to keep it simple and require v20 or later regardless of the > streaming option. Since streaming defaults to parallel, the > subscribers would have to give up the performance benefit of > streaming. So I don't think it's worth adding another check for them, > as Amit said.
Yeah, that sounds reasonable to me. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
