Hi Melanie, Thank you for starting this thread and the patches.
I tested v1 0001+0002 on master (65ebed1f5e2) and did a couple of tests: 1. make check passes, including the new test_vm_mask(). 2. Primary with wal_consistency_checking = all plus a streaming standby, running the regression suite against the primary (similar to 027_stream_regress with PG_TEST_EXTRA=wal_consistency_checking, huge wal was generated), the standby replayed everything with no inconsistent-page failures. 3. Crash recovery with wal_consistency_checking = all over a workload aimed at VM/PD_ALL_VISIBLE transitions (VACUUM and VACUUM FREEZE, VM clears from UPDATE/DELETE/row locks, on-access pruning, COPY FREEZE, VM truncation) they all look clean. I didn't see any false positives from unmasking either the VM bitmap or PD_ALL_VISIBLE. Otherwise both patches look good to me. Regards, Surya Poondla
