On Fri, Nov 20, 2026 at 6:17 PM Zsolt Parragi <[email protected]> wrote: > > > Stop masking PD_ALL_VISIBLE, as doing so can only conceal real bugs. > > Claude pointed out that wal_consistency_checking can trigger an error > with 0002. This uses very specific flags, but both > full_page_writes=off and disabled data checksums are supported, so it > seems like a plausible scenario.
Ah, right, I forgot that when we only sets the VM bits and both checksums/wal_log_hints are off, we can set PD_ALL_VISIBLE without advancing the heap page LSN. So, I suppose we can't do 0002. I'll replace it with a replacement of the comment explaining why we have to mask PD_ALL_VISIBLE. Thanks! - Melanie
