On Sun, Nov 4, 2018 at 11:17 AM Michael Paquier <mich...@paquier.xyz> wrote:
> On Sat, Nov 03, 2018 at 03:56:14PM +0530, Amit Kapila wrote: > > Before trying out any solution or deciding which is better, I think we > > want to understand why the variability in results occurred only after > > your patch? Without the patch, it works just fine. > > Good point. We surely want to have a stable feature, which gets tested > without triggering random failures in the builfarm. > Thanks for the review. This patch has changed the pg_stat_statements_reset() function from returning void to number statements that it reset. The regression test contains pg_stat_statements_reset() as first query to reset any of the query stats that are already tracked to let the test to provide the proper results. But with this feature, if we test this regression test on an already running server, the first query result is varying and it leads to test failure. So to fix this problem, I added a wrapper function that masks the result of the pg_stat_statements_reset() function and just return as void, with this wrapper function used a first statement, the test is stable, as this function takes care of resetting already existing statements from the already running server. With the above change, the regression test is stable. Comments? Regards, Haribabu Kommi Fujitsu Australia
