Hi, Thank you updating the patch and adding notes to the documentation about the points I raised.
On 2018/11/07 9:53, Michael Paquier wrote: > On Tue, Nov 06, 2018 at 07:04:17PM +0900, Amit Langote wrote: >> Agree with keeping it simple. Maybe, we could (should?) document that the >> only ON COMMIT action that works when specified with partitioned parent >> table is DROP (other actions are essentially ignored)? > > I have been thinking about this one, and here are some ideas: > - for ON COMMIT DROP: > When used on a partitioned table or a table with inheritance children, > this drops the depending partitions and children. > - for ON DELETE ROWS: > When used on a partitioned table, this is not cascaded to its > partitions. I looked at the documentation patch regarding this: @@ -1225,7 +1226,9 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM <listitem> <para> The temporary table will be dropped at the end of the current - transaction block. + transaction block. When used on a partitioned table or a + table with inheritance children, this drops the depending + partitions and children. How about: When used on tables with inheritance children (including partitioned tables), this also drops the children (partitions). Thanks, Amit