On Thu, Nov 08, 2018 at 12:53:18PM -0500, Robert Haas wrote: > On Thu, Nov 8, 2018 at 4:04 AM Michael Paquier <mich...@paquier.xyz> wrote: >> Even if the style gets heavier, I have also the following in my box: >> When used on a partitioned table, this action drops its partitions and >> when used on tables with inheritance children, it drops the depending >> children. > > It should be "dependent" not "depending".
Thanks for the feedback! I have committed and back-patched but actually I am only back-patching that stuff down to v10 as I have noticed the following limitation on 9.6 and older versions when cascading ON COMMIT DROP using this test case: begin; create temp table temp_inh_oncommit_test (a int) on commit drop; create temp table temp_inh_oncommit_test1 () inherits(temp_inh_oncommit_test) on commit delete rows; insert into temp_inh_oncommit_test1 values (1); commit; At commit time, there is an annoying NOTICE message which should not show up because of the automatic cascading drop: NOTICE: drop cascades to table temp_inh_oncommit_test1 The issue is that PERFORM_DELETION_QUIETLY is not available back then, and this requires a bit of refactoring around reportDependentObjects(), particularly changing silently one of its arguments which seems risky to introduce on a stable branch, so I am taking the safest path (this is a static routine but I am ready to bet that some forks would be unhappy with the suddent change and that may not trigger a compilation failure). This bug is also quite old, and there have not been complains until I discovered it, so it does not seem worth taking any risk. -- Michael
signature.asc
Description: PGP signature