> On Mon, 16 Jul 2018 at 23:07, Tomas Vondra <tomas.von...@2ndquadrant.com> > wrote: > > On 07/16/2018 05:24 PM, Robert Haas wrote: > > On Sun, Jul 15, 2018 at 6:53 AM, Vik Fearing > > <vik.fear...@2ndquadrant.com> wrote: > >> Hmm. Not sure if that last word should be _sample, _sampling, _rate, or > >> a combination of those. > > > > +1 for rate or sample_rate. I think "sample" or "sampling" without > > "rate" will not be very clear. > > > > 1+ to sample_rate > > It's what auto_explain and pgbench uses, so let's keep the naming > consistent.
This patch went through last few commitfests without any activity, but cfbot says it still applies and doesn't break any tests. From what I see there was some agreement about naming, so the patch is indeed needs more review. Could anyone from the reviewers (Vik?) confirm that it's in a good shape?
