On Thu, Nov 29, 2018 at 10:04:12AM +0100, Christoph Berg wrote:
> There's hundreds of other internal uses of xlog that were not touched
> either, only the user-facing parts were changed.

I have heard of them ;)
Just wondering if this one is worth renaming as the variable is
isolated.  It is not a big deal to do nothing though.

> If this gets accepted, I'll submit a patch for pgbadger so it can be
> updated before PG12 hits the field.

Your change looks acceptable to me FWIW.
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to