=# select name, short_desc, extra_desc, category from pg_settings where category like 'Reporting%When%' ; ─[ RECORD 1 ]──────────────────────────────────────────────────────────────────────────────────────────────────── name │ log_min_duration_statement short_desc │ Sets the minimum execution time above which statements will be logged. extra_desc │ Zero prints all queries. -1 turns this feature off. category │ Reporting and Logging / When to Log ─[ RECORD 2 ]──────────────────────────────────────────────────────────────────────────────────────────────────── name │ log_min_error_statement short_desc │ Causes all statements generating error at or above this level to be logged. extra_desc │ Each level includes all the levels that follow it. The later the level, the fewer messages are sent. category │ Reporting and Logging / When to Log ─[ RECORD 3 ]──────────────────────────────────────────────────────────────────────────────────────────────────── name │ log_min_messages short_desc │ Sets the message levels that are logged. extra_desc │ Each level includes all the levels that follow it. The later the level, the fewer messages are sent. category │ Reporting and Logging / When to Log ─[ RECORD 4 ]──────────────────────────────────────────────────────────────────────────────────────────────────── name │ log_statement_sample_rate short_desc │ Fraction of statements to log. extra_desc │ 1.0 logs all statements. category │ Reporting and Logging / When to Log
The description here seems a bit short on details to me. I would say something like "Fraction of statements over log_min_duration_statement to log"; otherwise it's not clear why this doesn't apply to log_statement. I think the extra_desc should be more verbose too. (Not really clear to me what to put in each ... suggestions welcome.) (More generally, I think we should add a lot more juice to the GUC description fields.) Attached is pgindent fixes for your next submission. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 5830d3292a0c12bd0a21213ffb4926eac8c2bdb8 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera <alvhe...@alvh.no-ip.org> Date: Thu, 29 Nov 2018 10:15:11 -0300 Subject: [PATCH] pgindent --- src/backend/tcop/postgres.c | 6 +++--- src/backend/utils/misc/guc.c | 2 +- src/include/utils/guc.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 6777eebde1..7565f57988 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -2242,9 +2242,9 @@ check_log_duration(char *msec_str, bool was_logged) secs * 1000 + msecs >= log_min_duration_statement))); /* - * Do not log if log_statement_sample_rate = 0. - * Log a sample if log_statement_sample_rate <= 1 and avoid unecessary - * random() call if log_statement_sample_rate = 1. + * Do not log if log_statement_sample_rate = 0. Log a sample if + * log_statement_sample_rate <= 1 and avoid unecessary random() call + * if log_statement_sample_rate = 1. */ in_sample = log_statement_sample_rate != 0 && (log_statement_sample_rate == 1 || diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 0cae141530..01bab32ea8 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -486,7 +486,7 @@ int log_min_messages = WARNING; int client_min_messages = NOTICE; int log_min_duration_statement = -1; int log_temp_files = -1; -double log_statement_sample_rate = 1.0; +double log_statement_sample_rate = 1.0; int trace_recovery_messages = LOG; int temp_file_limit = -1; diff --git a/src/include/utils/guc.h b/src/include/utils/guc.h index 4c5cabcc5f..64457c792a 100644 --- a/src/include/utils/guc.h +++ b/src/include/utils/guc.h @@ -251,7 +251,7 @@ extern PGDLLIMPORT int log_min_messages; extern PGDLLIMPORT int client_min_messages; extern int log_min_duration_statement; extern int log_temp_files; -extern double log_statement_sample_rate; +extern double log_statement_sample_rate; extern int temp_file_limit; -- 2.11.0
