James Coleman <jtc...@gmail.com> writes: > One other question on testing: do you think the "calculated array" > tests are good enough by themselves (i.e., remove the ones with array > constants of > 100 values)? I dislike that it's not as obvious what's > going on, but given that the code shouldn't care about array size > anyway...so if there's an inclination to fewer tests that's the first > place I'd look at cutting them.
I don't have a strong opinion about that at this point. It might be clearer once the patch is finished; for now, there's no harm in erring towards the more-tests direction. regards, tom lane