On 2019-Feb-11, Alvaro Herrera wrote: > On 2019-Feb-07, Arseny Sher wrote: > > > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > > > Ah, okay. Does the test still fail when run without the code fix? > > > > Yes. The problem here is overriding cmax of catalog (pg_attribute in the > > test) tuples, so it fails without any data at all. > > Makes sense. > > I thought the blanket removal of the assert() was excessive, and we can > relax it instead; what do you think of the attached?
More precisely, my question was: with this change, does the code still work correctly in your non-toy case? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services