On 2019-Feb-12, Arseny Sher wrote: > > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > >> I thought the blanket removal of the assert() was excessive, and we can > >> relax it instead; what do you think of the attached? > > > > More precisely, my question was: with this change, does the code still > > work correctly in your non-toy case? > > Yes, it works. I thought for a moment that some obscure cases where cmax > on a single tuple is not strictly monotonic might exist, but looks like > they don't. So your change is ok for me, reshaping assert is better than > removing. make check is also good on all supported branches.
Thanks for checking! I also run it on all branches, everything passes. Pushed now. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
