Hi, On 2019-03-18 17:13:01 +0900, Michael Paquier wrote: > +/* > + * Locations of persistent and temporary control files. The control > + * file gets renamed into a temporary location when enabling checksums > + * to prevent a parallel startup of Postgres. > + */ > +#define CONTROL_FILE_PATH "global/pg_control" > +#define CONTROL_FILE_PATH_TEMP CONTROL_FILE_PATH > ".pg_checksums_in_progress"
I think this should be outright rejected. Again, you're making the control file into something it isn't. And there's no buyin for this as far as I can tell outside of Fabien and you. For crying out loud, if the server crashes during this YOU'VE CORRUPTED THE CLUSTER. - Andres
