On Sat, May 4, 2019 at 1:29 PM Tom Lane <[email protected]> wrote: > Thomas Munro <[email protected]> writes: > > On Sat, May 4, 2019 at 10:29 AM Tom Lane <[email protected]> wrote: > > + Tolerate <literal>EINVAL</literal> and <literal>ENOSYS</literal> > > + error results, where appropriate, for fsync calls (Thomas Munro, > > + James Sewell) > > > Nit-picking: ENOSYS is for sync_file_range, EINVAL is for fsync. > > Yeah, I didn't really think it was worth distinguishing. If there > is some more general term that covers both calls, maybe we should > use that?
I would just do s/fsync/fsync and sync_file_range/. And I guess also wrap them in <function>? -- Thomas Munro https://enterprisedb.com
