On 2019-May-15, Tom Lane wrote:
> Alvaro Herrera <alvhe...@2ndquadrant.com> writes:
> > Here's a bunch of message fixes in the postgres.po module. Please
> > comment if anything seems amiss.
>
> These sorts of changes trouble me a bit from a translatability standpoint:
>
> - errmsg("connect = false and enabled = true are mutually
> exclusive options")));
> + errmsg("%s and %s are mutually exclusive options",
> + "connect = false", "enabled = true")));
>
> - (errmsg("CREATE_REPLICATION_SLOT ... USE_SNAPSHOT "
> - "must not be called in a subtransaction")));
> + (errmsg("%s must not be called in a subtransaction",
> + "CREATE_REPLICATION_SLOT ...
> USE_SNAPSHOT")));
>
> A translator might expect the %s's to represent single words.
> I think at least you'd want a translator: comment to warn about
> what the insertion will be.
Fair point, I can add that. (As a translator, I know I have to
reference the source files more often than I would like.) :-(
> + /* XXX is it okay to use %d for BlockNumber everywhere? */
>
> BlockNumber should be %u, no?
Yeah. It's %d in basebackup.c, hence the comment. I think technically
it's okay most of the time, because it's only used to reference to block
numbers in a *file*, not a relation; however, I fear it might still
break in cases of a very large --with-segsize option.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
