Hi, On 2019-08-05 12:43:24 -0400, Tom Lane wrote: > Yeah, good point. There are a lot of other cases where you really > don't want system startup to happen, too.
Agreed. > On the other hand, people have also opined that they want full error > checking on the inserted values, and that seems out of reach with less > than a full running system (mumble extensions mumble). I think the error checking ought to be about as complete as the one we do during a normal postmaster startup. Afaict that requires loading shared_preload_library extensions, but does *not* require booting up far enough to run GUC checks in a context with database access. The one possible "extension" to that that I can see is that arguably we might want to error out if DefineCustom*Variable() doesn't think the value is valid for a shared_preload_library, rather than just WARNING (i.e. refuse to start). We can't really do that for other libraries, but for shared_preload_libraries it might make sense. Although I suspect the better approach would be to just generally convert that to an error, rather than having some startup specific logic. Greetings, Andres Freund
