Hi, On 2019-09-12 09:57:55 -0300, Alvaro Herrera wrote: > On 2019-Sep-12, Tomas Vondra wrote: > > > On Wed, Sep 11, 2019 at 09:51:40AM -0300, Alvaro Herrera from 2ndQuadrant > > wrote: > > > On 2019-Sep-11, Amit Khandekar wrote: > > > > I think doing this all the time would make restore very slow -- there's a > > > reason we keep the files open, after all. > > > > How much slower? It certainly will have a hit, but maybe it's negligible > > compared to all the other stuff happening in this code?
I'd expect it to be significant. > > As a sidenote - in the other thread about streaming, one of the patches > > does change how we log subxact assignments. In the end, this allows using > > just a single file for the top-level transaction, instead of having one > > file per subxact. That would also solve this. Uhm, how is rollback to savepoint going to be handled in that case? I don't think it's great to just retain space for all rolled back subtransactions. Greetings, Andres Freund
