On Thu, Feb 13, 2020 at 4:51 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Thu, Feb 13, 2020 at 3:23 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > Forking this thread for two tangential patches which I think are more > > worthwhile than the original topic's patch. > > https://www.postgresql.org/message-id/20200207143935.GP403%40telsasoft.com > > > > Is there a better place to implement assertion from 0002 ? > > I would think the answer to that would be related to the answer of why > you think we need this assert in the first place? > > I know I have made the mistake of not updating relnatts when I added > relispartition, etc. to pg_class, only to be bitten by it in the form > of seemingly random errors/crashes. Is that why?
Sorry for not having read the patch properly. > + /* Check that pg_class data is consistent now, rather than failing > obscurely later */ That seems to be it. Thanks, Amit