On Fri, Mar 20, 2020 at 04:58:08PM +0530, Amit Kapila wrote: > See, how the attached looks? I have written a commit message as well, > see if I have missed anyone is from the credit list?
Thanks for looking again. Couple tweaks: +/* Phases of vacuum during which an error can occur. */ Can you say: "during which we report error context" Otherwise it sounds like we've somehow precluded errors from happening anywhere else, which I don't think we can claim. In the commit messsage: |The additional information displayed will be block number for errors |occurred while processing heap and index name for errors occurred |while processing the index. => error occurring |This will help us in diagnosing the problems that occurred during a |vacuum. For ex. due to corruption if we get some error while vacuuming, => problems that occur Maybe it should say that this will help both 1) admins who have corruption due to hardware (say); and, 2) developer's with corruption due to a bug. -- Justin
