On Sat, Mar 21, 2020 at 01:00:03PM +0530, Amit Kapila wrote: > I have addressed your comments in the attached patch. Today, while > testing error messages from various phases, I noticed that the patch > fails to display error context if the error occurs during the truncate > phase. The reason was that we had popped the error stack in > lazy_scan_heap due to which it never calls the callback. I think we > need to set up callback at a higher level as is done in the attached > patch. I have done the testing by inducing errors in various phases > and it prints the required information. Let me know what you think of > the attached?
Thanks. My tests with TRUNCATE were probably back when we had multiple push/pop cycles of local error callbacks. This passes my tests. -- Justin
