On Wed, Apr 01, 2020 at 02:43:10AM +0900, Fujii Masao wrote: > > > On 2020/03/31 16:33, Julien Rouhaud wrote: > > > > v12 attached! > > Thanks for updating the patch! The patch looks good to me. > > I applied minor and cosmetic changes into the patch. Attached is > the updated version of the patch. Barring any objection, I'd like to > commit this version. > > BTW, the minor and cosmetic changes that I applied are, for example, > > - Rename pgss_planner_hook to pgss_planner for the sake of consistency. > Other function using hook in pgss doesn't use "_hook" in their names, too. > - Make pgss_planner use PG_FINALLY() instead of PG_CATCH(). > - Make PGSS_NUMKIND as the last value in enum pgssStoreKind.
+1, and the PGSS_INVALID is also way better. > - Update the sample output in the document. > etc Thanks a lot. It all looks good to me!
