Peter Geoghegan <p...@bowt.ie> writes: > On Mon, Sep 21, 2020 at 2:09 PM Robert Haas <robertmh...@gmail.com> wrote: >> +REVOKE ALL ON FUNCTION >> +verify_heapam(regclass, boolean, boolean, cstring, bigint, bigint) >> +FROM PUBLIC; >> >> This too.
> Do we really want to use a cstring as an enum-like argument?
Ugh. We should not be using cstring as a SQL-exposed datatype
unless there really is no alternative. Why wasn't this argument
declared "text"?
regards, tom lane
