On Thu, Mar 4, 2021 at 12:40 PM tsunakawa.ta...@fujitsu.com < tsunakawa.ta...@fujitsu.com> wrote:
> From: Zhihong Yu <z...@yugabyte.com> > > This feature enables bulk COPY into foreign table in the case of > > multi inserts is possible > > > > 'is possible' -> 'if possible' > > > > FDWAPI was extended by next routines: > > > > next routines -> the following routines > > Thank you, fixed slightly differently. (I feel the need for pgEnglish > again.) > > > > + if ((!OK && PQresultStatus(res) != PGRES_FATAL_ERROR) || > > > > Is PGRES_FATAL_ERROR handled somewhere else ? I don't seem to find that > in the patch. > > Good catch. ok doesn't need to be consulted here, because failure during > row transmission causes PQputCopyEnd() to receive non-NULL for its second > argument, which in turn makes PQgetResult() return non-COMMAND_OK. > > > Regards > Takayuki Tsunakawa > > This patch set no longer applies http://cfbot.cputube.org/patch_32_2601.log Can we get a rebase? I am marking the patch "Waiting on Author" -- Ibrar Ahmed
