On Wed, Mar 3, 2021 at 5:45 PM Justin Pryzby <pry...@telsasoft.com> wrote:
> I'm proposing some minor changes. > > Some additional tweaks/comments for the documentation with the edit proposed edits: (edit) + <function>PQresultStatus</function>, will report a Remove the comma (orig) + the failed operation are skipped entirely. The same behaviour holds if the We seem to use "behavior" more frequently (edit) + From the client perspective, after <function>PQresultStatus</function> Possessive "client's perspective" (edit) + its expected results queue. Based on available memory, results from the "its corresponding results queue" - to go along with this change: - of the order in which it sent queries and the expected results. + of the order in which it sent queries, to associate them with their + corresponding results. (orig) + pipeline mode. If the current statement isn't finished processing + or there are results pending for collection with Needs a comma after processing. "results pending for collection" reads oddly to me...not sure what would be better though... (edit) + <note> + <para> + The pipeline API was introduced in <productname>PostgreSQL</productname> 14. + Pipeline mode is a client-side feature which doesn't require server + support, and works on any server that supports the v3 extended query + protocol. + </para> + </note> This note seems like it should be placed either near the very beginning of the feature or incorporated into the feature introduction. (orig) + If any statement encounters an error, the server aborts the current +(-) transaction and skips processing commands in the pipeline until the + next synchronization point established by <function>PQsendPipeline</function>. I dislike "skips" here - even if it doesn't execute a command it still will place a result on the socket so that the client can have something to match up with the queries it sent, correct? + transaction and creates a PGRES_PIPELINE_ABORTED result for all commands in the pipeline until the David J.
