> On Mar 12, 2021, at 2:55 PM, Robert Haas <robertmh...@gmail.com> wrote: > > On Fri, Mar 12, 2021 at 5:24 PM Mark Dilger > <mark.dil...@enterprisedb.com> wrote: >> This does nothing to change the verbiage from contrib/amcheck, but it should >> address the problems discussed here in pg_amcheck's regression tests. > > Committed.
Thanks. There are two more, attached here. The first deals with error message text which differs between farm animals, and the second deals with an apparent problem with IPC::Run shell expanding an asterisk on some platforms but not others. That second one, if true, seems like a problem with scope beyond the pg_amcheck project, as TestLib::command_checks_all uses IPC::Run, and it would be desirable to have consistent behavior across platforms.
v2-0001-Fixing-pg_amcheck-regression-test-portability-iss.patch
Description: Binary data
v2-0002-Working-around-apparent-difficulty-in-IPC-Run.patch
Description: Binary data
— Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company