On Fri, Mar 12, 2021 at 10:32 AM Peter Geoghegan <[email protected]> wrote:
> Thank you both, Mark and Robert. This is excellent work!
FYI I see these compiler warnings just now:
pg_amcheck.c:1653:4: warning: ISO C90 forbids mixed declarations and
code [-Wdeclaration-after-statement]
1653 | DatabaseInfo *dat = (DatabaseInfo *)
pg_malloc0(sizeof(DatabaseInfo));
| ^~~~~~~~~~~~
pg_amcheck.c: In function ‘compile_relation_list_one_db’:
pg_amcheck.c:2060:9: warning: variable ‘is_btree’ set but not used
[-Wunused-but-set-variable]
2060 | bool is_btree = false;
| ^~~~~~~~
Looks like this 'is_btree' variable should be PG_USED_FOR_ASSERTS_ONLY.
--
Peter Geoghegan
