> > ... FWIW, I'd rather > > agree to use what has been proposed with es_opened_result_relations > > like TRUNCATE does rather than attempt to use ExecInitResultRelation() > > combined with potentially asymmetric calls to > > ExecCloseResultRelations(). > > Okay, how about the attached then? I decided to go with just finish_estate(), > because we no longer have to do anything relation specific there. >
I think the patch looks good. But I noticed that there seems no testcase to test the [aftertrigger in subscriber] when using logical replication. As we seems planned to do some further refactor in the future, Is it better to add one testcase to cover this code ? Best regards, houzj
