On Tue, Apr 20, 2021 at 4:59 PM houzj.f...@fujitsu.com <houzj.f...@fujitsu.com> wrote: > > > > ... FWIW, I'd rather > > > agree to use what has been proposed with es_opened_result_relations > > > like TRUNCATE does rather than attempt to use ExecInitResultRelation() > > > combined with potentially asymmetric calls to > > > ExecCloseResultRelations(). > > > > Okay, how about the attached then? I decided to go with just > > finish_estate(), > > because we no longer have to do anything relation specific there. > > > > I think the patch looks good. > But I noticed that there seems no testcase to test the [aftertrigger in > subscriber] when using logical replication. > As we seems planned to do some further refactor in the future, Is it better > to add one testcase to cover this code ? >
+1. I think it makes sense to add a test case especially because we don't have any existing test in this area. -- With Regards, Amit Kapila.
