On Sun, May 2, 2021 at 10:04 PM vignesh C <vignes...@gmail.com> wrote:
>
> Thanks for the comments.
> The Attached patch has the fixes for the same.
I was reviewing the documentation part, I think in the below paragraph
we should include validate_publication as well?
<varlistentry>
<term><literal>connect</literal> (<type>boolean</type>)</term>
<listitem>
<para>
Specifies whether the <command>CREATE SUBSCRIPTION</command>
should connect to the publisher at all. Setting this to
<literal>false</literal> will change default values of
<literal>enabled</literal>, <literal>create_slot</literal> and
<literal>copy_data</literal> to <literal>false</literal>.
</para>
I will review/test the other parts of the patch and let you know.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
