Hi, For some of the logical replication messages the data type documented was not correct, especially for lsn and xid. For lsn actual datatype used is uint64 but is documented as int64, similarly for xid, datatype used is uint32 but documented as int32. Attached is a patch which has the fix for the same. Thoughts?
Regards, Vignesh
From 97e110370350d3ac971daf675a7102292421de00 Mon Sep 17 00:00:00 2001 From: vignesh <vignes...@gmail.com> Date: Sun, 9 May 2021 17:57:08 +0530 Subject: [PATCH v1] Corrected data type for the logical replication message formats. Corrected data type for the logical replication message formats. --- doc/src/sgml/protocol.sgml | 52 +++++++++++++++++++------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 2f4dde3beb..aad84603a8 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -6403,7 +6403,7 @@ Begin </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -6424,7 +6424,7 @@ Begin </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6458,7 +6458,7 @@ Message </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6480,7 +6480,7 @@ Message </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -6544,7 +6544,7 @@ Commit </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -6554,7 +6554,7 @@ Commit </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -6599,7 +6599,7 @@ Origin </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -6648,7 +6648,7 @@ Relation </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6659,7 +6659,7 @@ Relation </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6702,7 +6702,7 @@ Relation <varlistentry> <term> - Int16 + Uint16 </term> <listitem> <para> @@ -6780,7 +6780,7 @@ Type </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6791,7 +6791,7 @@ Type </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6845,7 +6845,7 @@ Insert </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6856,7 +6856,7 @@ Insert </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6912,7 +6912,7 @@ Update </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -6923,7 +6923,7 @@ Update </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7026,7 +7026,7 @@ Delete </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7037,7 +7037,7 @@ Delete </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7115,7 +7115,7 @@ Truncate </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7147,7 +7147,7 @@ Truncate </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7193,7 +7193,7 @@ Stream Start </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7262,7 +7262,7 @@ Stream Commit </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7282,7 +7282,7 @@ Stream Commit </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -7292,7 +7292,7 @@ Stream Commit </varlistentry> <varlistentry> <term> - Int64 + Uint64 </term> <listitem> <para> @@ -7337,7 +7337,7 @@ Stream Abort </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> @@ -7347,7 +7347,7 @@ Stream Abort </varlistentry> <varlistentry> <term> - Int32 + Uint32 </term> <listitem> <para> -- 2.25.1
