On Sun, May 9, 2021 at 11:13 PM Peter Smith <smithpb2...@gmail.com> wrote: > > On Sun, May 9, 2021 at 10:38 PM vignesh C <vignes...@gmail.com> wrote: > > > > Hi, > > > > For some of the logical replication messages the data type documented > > was not correct, especially for lsn and xid. For lsn actual datatype > > used is uint64 but is documented as int64, similarly for xid, datatype > > used is uint32 but documented as int32. > > Attached is a patch which has the fix for the same. > > Thoughts? > > If you want to do this then there are more - e.g. Flags should be > Uint8 instead of Int8.
Irrespective of signed/unsigned, from the description of types [1] it does seem like all those unused "(must be 0)" replication flags ought to have been written as "Int8(0)" instead of "Int8". ------ [1] https://www.postgresql.org/docs/devel/protocol-message-types.html Kind Regards, Peter Smith. Fujitsu Australia
