On Mon, May 31, 2021 at 09:07:38PM -0400, Tom Lane wrote: > Michael Paquier <mich...@paquier.xyz> writes: >>> Agreed, that seems bogus. > >> There may be others, and I have not checked yet. I'd rather do a >> backpatch for this part, would you agree? > > +1
Playing with all those variables and broken values here and there, I have been able to break a bunch of tests. Most of the failures were in the authentication and SSL tests, but there were also fancier cases. For example, PGCLIENTENCODING would cause a failure with pg_ctl, for any TAP test. I got surprised that enforcing values for most of the PGSSL* ones did not cause a failure when it came to the certs, CRLs keys and root certs now. Still, I think that we'd be safer to cancel these as well. Attached is the list I am finishing with. I'd like to fix that, so please let me know if there are any comments or objections. -- Michael
diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
index d6c3eb8723..d4f9fc5f2b 100644
--- a/src/test/perl/TestLib.pm
+++ b/src/test/perl/TestLib.pm
@@ -104,13 +104,30 @@ BEGIN
delete $ENV{LC_ALL};
$ENV{LC_MESSAGES} = 'C';
+ delete $ENV{PGCHANNELBINDING};
+ delete $ENV{PGCLIENTENCODING};
delete $ENV{PGCONNECT_TIMEOUT};
delete $ENV{PGDATA};
delete $ENV{PGDATABASE};
+ delete $ENV{PGGSSENCMODE};
+ delete $ENV{PGGSSLIB};
delete $ENV{PGHOSTADDR};
+ delete $ENV{PGKRBSRVNAME};
+ delete $ENV{PGPASSFILE};
+ delete $ENV{PGPASSWORD};
+ delete $ENV{PGREQUIREPEER};
delete $ENV{PGREQUIRESSL};
delete $ENV{PGSERVICE};
+ delete $ENV{PGSERVICEFILE};
+ delete $ENV{PGSSLCERT};
+ delete $ENV{PGSSLCRL};
+ delete $ENV{PGSSLCRLDIR};
+ delete $ENV{PGSSLKEY};
+ delete $ENV{PGSSLMAXPROTOCOLVERSION};
+ delete $ENV{PGSSLMINPROTOCOLVERSION};
delete $ENV{PGSSLMODE};
+ delete $ENV{PGSSLROOTCERT};
+ delete $ENV{PGSSLSNI};
delete $ENV{PGUSER};
delete $ENV{PGPORT};
delete $ENV{PGHOST};
signature.asc
Description: PGP signature
