On Wed, 7 Jul 2021 at 02:54, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Minor nit: use "const char *text" in the struct declaration, so > that all of the static data can be placed in fixed storage.
Thanks for pointing that out. > David Rowley <dgrowle...@gmail.com> writes: > > (I'm not sure why pgindent removed the space between != and NULL, but > > it did, so I left it.) > > It did that because "text" is a typedef name, so it's a bit confused > about whether the statement is really a declaration. Personally I'd > have used "name" or something like that for that field, anyway. I should have thought of that. Thanks for highlighting it. I've renamed the field. Updated patch attached. David
v2-0001-Use-lookup-table-for-units-in-pg_size_pretty-and-.patch
Description: Binary data
