Brendan Jurd wrote: > On 11/6/07, Bruce Momjian <[EMAIL PROTECTED]> wrote: > > > > I understand your suggestions but it seems there would be too many > > individual items to be readable. Can you suggest a full list so we can > > get an idea of how long it would be? > > If the body of material on writing good Postgres code becomes so > comprehensive that it doesn't all fit on one page: > > a) I would see that as a positive! > b) We can of course split it up into sub-articles. > > I can't realistically suggest a "full list" since I am not an > experienced Postgres hacker. But I would hope for, as a minimum: > > * the stuff about good GETARG style, > * something about using ereport() effectively, and writing > localization-friendly messages, > * some actual coding style guidelines.
The problem is that a full list would be harder to understand than just looking at the existing code and following it, or taking suggestions from us as we review the patch. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq