Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Alvaro Herrera wrote: > >> indent needs the typedef list. Maybe we can hack something based on > >> typedefs in the source code, instead of object files. > > > The only think of is to grab typedefs from the object file and then also > > try to get them from the souce too and combine them and remove duplicates. > > Something I noticed the other day is that pgindent doesn't seem to treat > "struct foo" or "union foo" as a type name, which is pretty silly > because no context is needed at all to recognize that. We tend not to > do that too much --- the project style is to use a typedef name --- but > there are some places that do it, particularly the regex code. For > instance there are extra spaces here: > > static void > cmtreefree(struct colormap * cm, > union tree * tree, > int level) /* level number (top == 0) of this block */ > { > > Fixable?
Yes, I found those are 't' STABS rather than "T" which are used in cases where you do typedef struct {} name. The next pgindent will have those typedefs you want. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate