Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Agreed, but I suggest waiting till 8.4 is branched unless you are really
sure about this addition.  We freeze for 8.3.0 in less than 24 hours.

I am pretty damn sure it's OK. It's pretty low risk (change an unlink call to a rename call) and even if it's broken as my fist version was, it doesn't appear to break the build. It's working on the buildfarm. I want it in so if we have problems with 8.3 we don't have to go through the handstands I had to to find out what was broken.

After looking at the patch, my only question is how all those junk files
get cleaned up at "make clean".

                        

The symbols files we are keeping as a result of the patch are renamed into to the release or debug hierarchy (depending on what we're building). Those entire trees are removed by src/tools/msvc/clean.bat.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
      subscribe-nomail command to [EMAIL PROTECTED] so that your
      message can get through to the mailing list cleanly

Reply via email to