> Seems sane to me. I don't see the point of the HEAP_INSERT_BULK flag > bit --- providing or not providing bistate would cover that, and if > you have a bit as well then you have to define what the inconsistent > combinations mean. I concur with making all-zeroes be the typical > state of the flag bits, too.
Thanks for the design review. I had thought to make the inconsistent combinations fail an assertion, but I'm just as happy to leave it out altogether. > FWIW, we generally declare bitmask flag variables as int, unless > there's some really good reason to do otherwise. OK, thanks for the tip. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
