I installed and ran the citext tests both with and without the patch and had failures both times. The patch applied cleanly and the "make;make install" completed without errors. I have attached the two regression.diffs files, one without the patch applied and the other with the patch.
Regards, Ken Marshall
*** /opt/local/pg8/pgsql/contrib/citext/expected/citext_1.out Wed Nov 5 08:33:40 2008 --- /opt/local/pg8/pgsql/contrib/citext/results/citext.out Wed Nov 5 08:34:44 2008 *************** *** 122,146 **** SELECT 'B'::citext < 'a'::text AS t; -- text wins. t --- ! t (1 row) SELECT 'B'::citext <= 'a'::text AS t; -- text wins. t --- ! t (1 row) SELECT 'a'::citext > 'B'::text AS t; -- text wins. t --- ! t (1 row) SELECT 'a'::citext >= 'B'::text AS t; -- text wins. t --- ! t (1 row) -- Test implicit casting. citext casts to varchar, but not vice-versa. --- 122,146 ---- SELECT 'B'::citext < 'a'::text AS t; -- text wins. t --- ! f (1 row) SELECT 'B'::citext <= 'a'::text AS t; -- text wins. t --- ! f (1 row) SELECT 'a'::citext > 'B'::text AS t; -- text wins. t --- ! f (1 row) SELECT 'a'::citext >= 'B'::text AS t; -- text wins. t --- ! f (1 row) -- Test implicit casting. citext casts to varchar, but not vice-versa. *************** *** 159,183 **** SELECT 'B'::citext < 'a'::varchar AS t; -- varchar wins. t --- ! t (1 row) SELECT 'B'::citext <= 'a'::varchar AS t; -- varchar wins. t --- ! t (1 row) SELECT 'a'::citext > 'B'::varchar AS t; -- varchar wins. t --- ! t (1 row) SELECT 'a'::citext >= 'B'::varchar AS t; -- varchar wins. t --- ! t (1 row) -- A couple of longer examlpes to ensure that we don't get any issues with bad --- 159,183 ---- SELECT 'B'::citext < 'a'::varchar AS t; -- varchar wins. t --- ! f (1 row) SELECT 'B'::citext <= 'a'::varchar AS t; -- varchar wins. t --- ! f (1 row) SELECT 'a'::citext > 'B'::varchar AS t; -- varchar wins. t --- ! f (1 row) SELECT 'a'::citext >= 'B'::varchar AS t; -- varchar wins. t --- ! f (1 row) -- A couple of longer examlpes to ensure that we don't get any issues with bad ======================================================================
*** /opt/local/pg8/pgsql/contrib/citext/expected/citext_1.out Wed Nov 5 08:27:57 2008 --- /opt/local/pg8/pgsql/contrib/citext/results/citext.out Wed Nov 5 08:28:10 2008 *************** *** 122,146 **** SELECT 'B'::citext < 'a'::text AS t; -- text wins. t --- ! t (1 row) SELECT 'B'::citext <= 'a'::text AS t; -- text wins. t --- ! t (1 row) SELECT 'a'::citext > 'B'::text AS t; -- text wins. t --- ! t (1 row) SELECT 'a'::citext >= 'B'::text AS t; -- text wins. t --- ! t (1 row) -- Test implicit casting. citext casts to varchar, but not vice-versa. --- 122,146 ---- SELECT 'B'::citext < 'a'::text AS t; -- text wins. t --- ! f (1 row) SELECT 'B'::citext <= 'a'::text AS t; -- text wins. t --- ! f (1 row) SELECT 'a'::citext > 'B'::text AS t; -- text wins. t --- ! f (1 row) SELECT 'a'::citext >= 'B'::text AS t; -- text wins. t --- ! f (1 row) -- Test implicit casting. citext casts to varchar, but not vice-versa. *************** *** 159,183 **** SELECT 'B'::citext < 'a'::varchar AS t; -- varchar wins. t --- ! t (1 row) SELECT 'B'::citext <= 'a'::varchar AS t; -- varchar wins. t --- ! t (1 row) SELECT 'a'::citext > 'B'::varchar AS t; -- varchar wins. t --- ! t (1 row) SELECT 'a'::citext >= 'B'::varchar AS t; -- varchar wins. t --- ! t (1 row) -- A couple of longer examlpes to ensure that we don't get any issues with bad --- 159,183 ---- SELECT 'B'::citext < 'a'::varchar AS t; -- varchar wins. t --- ! f (1 row) SELECT 'B'::citext <= 'a'::varchar AS t; -- varchar wins. t --- ! f (1 row) SELECT 'a'::citext > 'B'::varchar AS t; -- varchar wins. t --- ! f (1 row) SELECT 'a'::citext >= 'B'::varchar AS t; -- varchar wins. t --- ! f (1 row) -- A couple of longer examlpes to ensure that we don't get any issues with bad *************** *** 740,769 **** t (1 row) - SELECT 'f'::char::citext = 'f' AS t; - t - --- - t - (1 row) - - SELECT 'f'::citext::char = 'f'::char AS t; - t - --- - t - (1 row) - - SELECT 'f'::"char"::citext = 'f' AS t; - t - --- - t - (1 row) - - SELECT 'f'::citext::"char" = 'f'::"char" AS t; - t - --- - t - (1 row) - SELECT 'foo'::citext::bytea = 'foo'::bytea AS t; t --- --- 740,745 ---- ======================================================================
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
