The help text for the pg_restore --clean option in the documentation is IMHO 
more precise than the
text that the pg_restore binary gives:

documentation:
 -c
 --clean
   Clean (drop) database objects before recreating them.

pg_restore binary:
   -c, --clean   clean (drop) schema prior to create


So I think it would be an improvement to channge the pg_restore --help text:


*** src/bin/pg_dump/pg_restore.c.orig   2008-12-27 01:16:23.000000000 +0100
--- src/bin/pg_dump/pg_restore.c        2008-12-27 01:29:53.000000000 +0100
***************
*** 385,391 ****

        printf(_("\nOptions controlling the restore:\n"));
        printf(_("  -a, --data-only          restore only the data, no 
schema\n"));
!       printf(_("  -c, --clean              clean (drop) schema prior to 
create\n"));
        printf(_("  -C, --create             create the target database\n"));
        printf(_("  -I, --index=NAME         restore named index\n"));
        printf(_("  -L, --use-list=FILENAME  use specified table of contents 
for ordering\n"
--- 385,391 ----

        printf(_("\nOptions controlling the restore:\n"));
        printf(_("  -a, --data-only          restore only the data, no 
schema\n"));
!       printf(_("  -c, --clean              clean (drop) database objects 
prior to creating
them\n"));
        printf(_("  -C, --create             create the target database\n"));
        printf(_("  -I, --index=NAME         restore named index\n"));
        printf(_("  -L, --use-list=FILENAME  use specified table of contents 
for ordering\n"



thanks,

Erik Rijkers



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to