Erik Rijkers wrote:
> The help text for the pg_restore --clean option in the documentation is IMHO 
> more precise than the
> text that the pg_restore binary gives:
> 
> documentation:
>  -c
>  --clean
>    Clean (drop) database objects before recreating them.
> 
> pg_restore binary:
>    -c, --clean   clean (drop) schema prior to create
> 
> 
> So I think it would be an improvement to channge the pg_restore --help text:

I used the wording from the pg_restore SGML manual page in the --help
text, to be more consistent.  Thanks for the report.

-- 
  Bruce Momjian  <br...@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: src/bin/pg_dump/pg_restore.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.90
diff -c -c -r1.90 pg_restore.c
*** src/bin/pg_dump/pg_restore.c	5 Jan 2009 16:54:37 -0000	1.90
--- src/bin/pg_dump/pg_restore.c	6 Jan 2009 17:17:10 -0000
***************
*** 391,397 ****
  
  	printf(_("\nOptions controlling the restore:\n"));
  	printf(_("  -a, --data-only          restore only the data, no schema\n"));
! 	printf(_("  -c, --clean              clean (drop) schema prior to create\n"));
  	printf(_("  -C, --create             create the target database\n"));
  	printf(_("  -I, --index=NAME         restore named index\n"));
  	printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"
--- 391,397 ----
  
  	printf(_("\nOptions controlling the restore:\n"));
  	printf(_("  -a, --data-only          restore only the data, no schema\n"));
! 	printf(_("  -c, --clean              clean (drop) database objects before recreating\n"));
  	printf(_("  -C, --create             create the target database\n"));
  	printf(_("  -I, --index=NAME         restore named index\n"));
  	printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to