Tom Lane wrote: > Heikki Linnakangas <heikki.linnakan...@enterprisedb.com> writes: > > Perhaps this could be made less ugly by only having the ScanKeywords > > array in the .c file, and #including that into other .c files in > > src/backend/parser, ecpg and pg_dump. > > What I'd suggest is something similar to the design of the errcodes.h > header: create a header file containing just the list of PG_KEYWORD > macro calls, and have the different users #include it after defining > that macro appropriately. Having .c files include other .c files is > usually best avoided on least-surprise grounds.
Seems doable. > > Not sure what to do about ScanKeywordLookup function. > > Yeah, duplicating that function is a bit annoying. Another new file, backend/parser/kwlookup.c perhaps? -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
