Alvaro Herrera <alvhe...@commandprompt.com> writes: > Hopefully this is the last version of this patch.
A few more comments would help --- in particular the header comment for kwlist.h should explain that the calling file is supposed to define PG_KEYWORD appropriately for its needs. I also wonder whether Greg isn't right that it would be better if the header contained *only* the PG_KEYWORD macros, rather than presupposing that the caller wants to build a constant table named ScanKeywords with them. In general though it's certainly cleaner than the old way. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers