Bernd Helmle escribió: > > > --On 30. September 2009 13:19:53 -0400 Alvaro Herrera > <alvhe...@commandprompt.com> wrote: > > >>I think it would be helpful if you could post ONE patch with all the > >>changes and all the new files in the diff. AIUI, "the" patch is now > >>split across three separate emails. :-( > > > >That's correct, here it is. > > Some additional notes: > > - ALTER ROLE ... IN DATABASE is missing some documentation. If you > want, i can work on this.
Please. > - The patch as is has still some locking problems (AlterRoleSet() > has a XXX about that): I've managed to create dead entries for a > role or a database in pg_db_role_setting while altering and dropping > a role/database in two concurrent sessions. Yeah, I was playing with that too. I think we need a few extra LockSharedObject calls, and not only in the new code :-( (This troubles me in the case of databases, because we already grab a lock on it during connection establishing, so this could cause extra contention there.) -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
