> Michael Paquier <michael.paqu...@gmail.com> wrote: > > Please find attached the latest version of the patch, > > with the threading bug corrected and the documentation updated as well.
Please don't describe your-specific usage of shell command in the documentation
> Why do you use BUFFER_SIZE-1 for snprintf?
> snprintf(commandShell, SHELL_COMMAND_SIZE-1, ...)
> Trailing nulls are also included in the length, so
> snprintf(commandShell, SHELL_COMMAND_SIZE, ...)
> would be ok. (removed -1)
I found several bugs and matters.
* The calcuration of the shell command length is wrong.
* You cannot assign 0 to variables with \setshell meta command.
* Comparison with "== true" is a bad manner.
* You called \shell "shell command" and \setsell "shell script",
but we don't need the difference. I think "shell command" is enough.
Heavily cleaned up patch attached. Please review it.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
pgbenchshell_20091210.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
