Michael Meskes írta: > On Mon, Jan 25, 2010 at 07:52:05PM +0100, Boszormenyi Zoltan wrote: > >> But considering all the above, we might not need the new >> compat_informix/struct.pgc regression test. I think it was tested >> already in e.g. preproc/array_of_struct.pgc and preproc/type.pgc >> and the new feature (if accepted) is a unified one, it would show >> the problem for native mode as well. >> > > That was my feeling too and the reason for these questions. Again, this has > nothing to do with the feature you implemented, it was just about this special > test. >
Should I send you a new patch without this regression test or do you delete it before applying the patch? BTW, thank you very much for the review. Best regards, Zoltán Böszörményi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
