On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote: > David Fetter <da...@fetter.org> writes: > > On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote: > >> Better write a check in the makefile. > > > That assumes that everyone will always actually run the > > appropriate make before committing, which I wouldn't assume, > > especially for a "trivial" patch that's going out when someone is > > pressed for time. Checking in an unavoidable place seems much > > more foolproof. > > The rule against tabs in SGML files is only a bit of anal > retentivity anyway. I don't think that enforcing it is worth > special hacks that we do not use anywhere else.
Good point. What other pre-commit hooks do we need? Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
