Fujii Masao wrote: > One problem of the patch is that even if the content of error message > is different from the past, it would be skipped when the location of > invalid record is the same of the past. For example, if there is a > partially-filled unbroken WAL file in the standby, the following > message would be written: > > record with zero length at %X/%X > > Then if you drop corrupted WAL file into pg_xlog, the following message > might have to be output, but would be skipped: > > invalid magic number %04X in log file %u, segment %u, offset %u > > > But I think that we might be able to live with the issue since it's > a very corner case.
Yeah, we can live with that. The user is not generally interested in what exactly is wrong with the record. It just indicates that it has the end of valid WAL in the standby. Applied. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
